[FFmpeg-devel] [RFC][PATCH] ticks_per_frame / timebase

[Michael Niedermayer]

On Thu, Feb 26, 2009 at 08:38:15PM +0100, Ivan Schreter wrote:
> Michael Niedermayer wrote:
>> On Thu, Feb 26, 2009 at 06:58:06PM +0100, Michael Niedermayer wrote:
>>   
>>> [...]
>>> yes i did forget something ...
>>>     
>>
>>   
> Do you have an update to your patch?

not yet


>
>> you seem to have forgetten a few things in your patch, for example
>> i suspect it generates random timestamps if the optional SEI mesages
>> are not pressent, it should generate AV_NOPTS_VALUE
>>
>>   
> Uhm, yes, true. Attached patch fixes it.
>
>> also you maybe are missing a check for sps.timing_info_present_flag,
>> iam not sure if it makes sense to check it or what to do if its not
>> set ...
>>
>>   
> Not needed, sei_cpb_removal_delay is set to -1 by default, so it's enough 
> to check for it, IMHO.

looks ok

also i think the reset of the sei vars should be in
decode_nal_units()
...
    if(!(s->flags2 & CODEC_FLAG2_CHUNKS)){
        h->current_slice = 0;
        if (!s->first_field)
            s->current_picture_ptr= NULL;
        <-----------------------here
    }

the reason is that just reseting at the end of a pic is "risky" if that end
isnt reached

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/f60d4435/attachment.pgp>