[FFmpeg-devel] [RFC][PATCH] ticks_per_frame / timebase

[Ivan Schreter]

Michael Niedermayer wrote:
> On Thu, Feb 26, 2009 at 06:58:06PM +0100, Michael Niedermayer wrote:
>   
>> [...]
>> yes i did forget something ...
>>     
>
>   
Do you have an update to your patch?

> you seem to have forgetten a few things in your patch, for example
> i suspect it generates random timestamps if the optional SEI mesages
> are not pressent, it should generate AV_NOPTS_VALUE
>
>   
Uhm, yes, true. Attached patch fixes it.

> also you maybe are missing a check for sps.timing_info_present_flag,
> iam not sure if it makes sense to check it or what to do if its not
> set ...
>
>   
Not needed, sei_cpb_removal_delay is set to -1 by default, so it's 
enough to check for it, IMHO.

Regards,

Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264_nots.patch
Type: text/x-patch
Size: 878 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/0ff9b200/attachment.bin>