[FFmpeg-devel] make ff_qcelp_lspf2lpc more general

[Kenan Gillet]

On Feb 26, 2009, at 8:23 AM, Reynaldo H. Verdejo Pinochet wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello
>
> Kenan Gillet wrote:
>>> -void ff_qcelp_lspf2lpc(const float *lspf, float *lpc)
>>> +void ff_qcelp_lspf2lpc(const double *lspf, float *lpc)
>>
>> was thinking of renaming it ff_celp_lspf2lpc since it is not anymore
>> related to only qcelp.
>
> Sure, better.
>
>> i tested it and u definitely need to drop the negative sign
>> double bandwith_expansion_coeff = QCELP_BANDWITH_EXPANSION_COEFF;
>
> Great, thanks. Passed my listening test as it is but didn't check
> for binary equivalence, did you?

did not pass binary equivalent without dropping the negative but the  
listening was ok.

>
>
>> on another note, it would be nice to split the commit into:
>> - splitting ff_qcelp_lspf2lpc into ff_qcelp_lspf2lpc(QCELP  
>> specific) +
>> ff_celp_lspf2lpc(any CELP)
>>   like in [1]
>> - moving the QCELP specific code to qcelpdec.c and qcelpdata.h
>
> Yeah, it would be better but I can't do that today. Now, if you
> provide an updated patchset I would do my best to get it commited
> by the end of the day.


no rush on my side, patches attached

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 1-extract_ff_celp_lspf2lpc.patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/37870427/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 2-mv_ff_qcelp_lspf2lpc_to_qcelp_files.patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090226/37870427/attachment-0001.txt>
-------------- next part --------------