[FFmpeg-devel] make ff_qcelp_lspf2lpc more general

[Reynaldo H. Verdejo Pinochet]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello

Kenan Gillet wrote:
>> -void ff_qcelp_lspf2lpc(const float *lspf, float *lpc)
>> +void ff_qcelp_lspf2lpc(const double *lspf, float *lpc)
> 
> was thinking of renaming it ff_celp_lspf2lpc since it is not anymore
> related to only qcelp.

Sure, better.

> i tested it and u definitely need to drop the negative sign
> double bandwith_expansion_coeff = QCELP_BANDWITH_EXPANSION_COEFF;

Great, thanks. Passed my listening test as it is but didn't check
for binary equivalence, did you?

> on another note, it would be nice to split the commit into:
> - splitting ff_qcelp_lspf2lpc into ff_qcelp_lspf2lpc(QCELP specific) +  
> ff_celp_lspf2lpc(any CELP)
>    like in [1]
> - moving the QCELP specific code to qcelpdec.c and qcelpdata.h

Yeah, it would be better but I can't do that today. Now, if you
provide an updated patchset I would do my best to get it commited
by the end of the day.

Bests
- --
Reynaldo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmmwgkACgkQwY4HfzEURSrilwCeJ/vM2OgPFN4YuSXvD+BjY/zU
+x0AnjyL/+NyHF6FXawtt9AEbuLaRRkI
=XSsF
-----END PGP SIGNATURE-----