[FFmpeg-devel] [PATCH] Create a libavutil/pix_fmt.h with the pixel format stuff

Måns Rullgård mans
Sat Feb 21 16:47:27 CET 2009


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Saturday 2009-02-21 15:34:50 +0100, Michael Niedermayer encoded:
>> On Sat, Feb 21, 2009 at 03:28:18PM +0100, Stefano Sabatini wrote:
>> > On date Friday 2009-02-20 21:08:55 +0100, Michael Niedermayer encoded:
>> > > On Thu, Feb 19, 2009 at 11:29:45PM +0100, Stefano Sabatini wrote:
>> > > > On date Thursday 2009-02-19 22:00:59 +0100, Stefano Sabatini encoded:
>> > > > > > > First step creates a pix_fmt.h header (PixFmtInfo would then be added
>> > > > > > > to libavutil/pix_fmt.c)
>> > > > > > 
>> > > > > > PixFmtInfo as is is too bloated, it requires cleanup _first_
>> > > > > > also your patch misses installing the new header while a installed header
>> > > > > > depends on it
>> > > > > 
>> > > > > Yes.
>> > > > > 
>> > > > > Also I'm not sure if pixfmt.h (no underscore) is a better name.
>> > > > 
>> > > > Uh, patch missing...
>> > > 
>> > > probably ok
>> > 
>> > This changes the public interface,
>> 
>> how so?
>
> She (the user) was used to do:
> #include <libavutil/avutil.h>
>
> while after the change she will do:
> #include <libavutil/pix_fmt.h>
>
> and get done with the pix fmt stuff inclusion, so she may do:
> #if (LIBAVUTIL_VERSION_MINOR < X)
> #include <libavutil/avutil.h>
> #else
> #include <libavutil/pix_fmt.h>
> #endif

Can we please call it pixfmt.h instead?  For no rational reason, I
like the look of that better.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list