[FFmpeg-devel] [PATCH] allow ac3 parser to modify codec_id

[Justin Ruggles]

Hi,

Joakim Plate wrote:
> Justin Ruggles <justin.ruggles <at> gmail.com> writes:
> 
>> I'm sorry... but I cannot find that file in incoming.
> 
> Was a long time ago, could have been moved or pruned.
> 
>> Does the audio not decode?  The decoder should handle E-AC3 content just
>> fine even though the codec id is CODEC_ID_AC3.  I do understand that
>> it's better to have it marked as the correct id though.
> 
> Well it may decode with libavcodec's decoder (haven't tested actually yet), 
> but currently we use a different decoder for standard AC3 which doesn't 
> support eac3. Thus unless libavformat set's the codecid properly we choose the 
> wrong decoder.

I hope you change your mind. :)

> If the parser would jump back and forth, there could be a point in only 
> allowing it to "upgrade" the stream from AC3 to EAC3, then as soon as a EAC3 
> frame is found it is marked as EAC3.

I applied your patch. It doesn't present an issue because the AC3 parser
does, in fact, group each independent frame with its dependent frame(s).

-Justin