[FFmpeg-devel] [PATCH] ffplay.c minor refactoring

[Benoit Fouet]

On 02/18/2009 03:56 PM, Michael Niedermayer wrote:
> On Wed, Feb 18, 2009 at 02:54:57PM +0200, Tomer Barletz wrote:
>   
>> On Wed, Feb 18, 2009 at 1:44 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>     
>>> On Wed, Feb 18, 2009 at 07:22:13AM +0200, Tomer Barletz wrote:
>>>       
>>>> On Wed, Feb 18, 2009 at 1:35 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>>>         
>>>>> On Tue, Feb 17, 2009 at 02:14:13PM +0200, Tomer Barletz wrote:
>>>>>           
>>>>>> Attached a minor patch which extracts some code from
>>>>>> video_refresh_timer into a new function - compute_field.
>>>>>>             
>>>>> if this just moves code out without changeing it then ok
>>>>>           
>>>> First, I would like to correct my previous statement - the new
>>>> function is compute_frame_delay, and not compute_field. Sorry for
>>>> that, I probably should get more sleep... ;)
>>>>
>>>> There are two semantic changes from the former code:
>>>> 1.
>>>> if (delay <= 0 || delay >= 10.0) {
>>>>   delay = is->frame_last_delay;
>>>> }
>>>> is->frame_last_delay = delay;
>>>>
>>>> is now:
>>>> if (delay <= 0 || delay >= 10.0)
>>>>   delay = is->frame_last_delay;
>>>> else
>>>>   is->frame_last_delay = delay;
>>>>
>>>> 2. The #if defined(DEBUG_SYNC) block will happened now before the call
>>>> to schedule_refresh, rather then after it in the previous code.
>>>>         
>>> these 2 must be seperate patches
>>>       
>> Attached:
>>     
>
>   
>> 1. extract_func.diff
>>     
>
> as said ok if it just extracts code ...
>
>
>   

applied, as it just does that

>> 2. unnecessary_assign.diff
>>     
>
> i would like to keep the {}
>
>
>   

applied (keeping the {} though)

>> 3. move_dbg_print.diff
>>     
>
> ok
>
>
> [...]
>
>   

applied (with indentation in the same commit, I guessed it was ok)

Ben