[FFmpeg-devel] [PATCH] ffplay.c minor refactoring

[Michael Niedermayer]

On Wed, Feb 18, 2009 at 07:22:13AM +0200, Tomer Barletz wrote:
> On Wed, Feb 18, 2009 at 1:35 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Feb 17, 2009 at 02:14:13PM +0200, Tomer Barletz wrote:
> >> Attached a minor patch which extracts some code from
> >> video_refresh_timer into a new function - compute_field.
> >
> > if this just moves code out without changeing it then ok
> 
> First, I would like to correct my previous statement - the new
> function is compute_frame_delay, and not compute_field. Sorry for
> that, I probably should get more sleep... ;)
> 
> There are two semantic changes from the former code:
> 1.
> if (delay <= 0 || delay >= 10.0) {
>   delay = is->frame_last_delay;
> }
> is->frame_last_delay = delay;
> 
> is now:
> if (delay <= 0 || delay >= 10.0)
>   delay = is->frame_last_delay;
> else
>   is->frame_last_delay = delay;
> 
> 2. The #if defined(DEBUG_SYNC) block will happened now before the call
> to schedule_refresh, rather then after it in the previous code.

these 2 must be seperate patches

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/63e2f45b/attachment.pgp>