[FFmpeg-devel] [PATCH] ffplay.c minor refactoring

[Tomer Barletz]

On Wed, Feb 18, 2009 at 1:44 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Feb 18, 2009 at 07:22:13AM +0200, Tomer Barletz wrote:
>> On Wed, Feb 18, 2009 at 1:35 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Tue, Feb 17, 2009 at 02:14:13PM +0200, Tomer Barletz wrote:
>> >> Attached a minor patch which extracts some code from
>> >> video_refresh_timer into a new function - compute_field.
>> >
>> > if this just moves code out without changeing it then ok
>>
>> First, I would like to correct my previous statement - the new
>> function is compute_frame_delay, and not compute_field. Sorry for
>> that, I probably should get more sleep... ;)
>>
>> There are two semantic changes from the former code:
>> 1.
>> if (delay <= 0 || delay >= 10.0) {
>>   delay = is->frame_last_delay;
>> }
>> is->frame_last_delay = delay;
>>
>> is now:
>> if (delay <= 0 || delay >= 10.0)
>>   delay = is->frame_last_delay;
>> else
>>   is->frame_last_delay = delay;
>>
>> 2. The #if defined(DEBUG_SYNC) block will happened now before the call
>> to schedule_refresh, rather then after it in the previous code.
>
> these 2 must be seperate patches

Attached:
1. extract_func.diff
2. unnecessary_assign.diff
3. move_dbg_print.diff

Tomer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extract_func.diff
Type: application/octet-stream
Size: 4153 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/8f27edfc/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnecessary_assign.diff
Type: application/octet-stream
Size: 582 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/8f27edfc/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move_dbg_print.diff
Type: application/octet-stream
Size: 850 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090218/8f27edfc/attachment-0002.obj>