[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Michael Niedermayer]

On Sun, Feb 15, 2009 at 05:09:01PM +0100, Reimar D?ffinger wrote:
> Hello,
> I was too fast at replying again.
> 
> On Sun, Feb 15, 2009 at 04:39:34PM +0100, Michael Niedermayer wrote:
> > > The thread_count thing is something that IMHO is a good thing to allow
> > > lavc to set in general, 
> > 
> > why? lavc can just ignore thread_count if it doesnt allow threads or fail
> > hard.
> > "Editng" thread_count is a permanent thing, think of
> > video1, video2, video3 concatenated
> > if something in video2 prevents decoding with 2 threads we dont want to
> > block video3 from using the number the user requested
> 
> Yes, but I don't consider requiring (to refer to a recent thread)
> "obscure incantations" to use lavc any good either.
> So that leaves ignoring. Do you have an idea how to ignore thread_count
> (and use the proper slice flags) when hardware-accelerated
> decoding is used, and in a way that works with selecting just the
> PIX_FMT via get_format and is not too messy?
> I am not particularly interested in learning the details of mpegvideo.c
> before I can decide which way might be acceptable.

if you have an internal thread_count that can easily be adjusted if needed
its done with h264 too as threads dont work in all cases ...


> 
> > > and the slice_flags... Well, I am not sure about
> > > the point of them...
> > 
> > well then rejected (if even the patch author doesnt know why ...)
> 
> And to clarify: I meant that I do not know why they are user-settable in the first
> place.

well the slice flags specify the limitations of the user app,
if mplayers limitations between xvmc and normal vo differ this is
mplayers problem.
you can just always set the slice flags if it works, it should be faster

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090215/05566264/attachment.pgp>