[FFmpeg-devel] [PATCH] set flags and stuff required for XvMC instead of just checking them

[Reimar Döffinger]

Hello,
I was too fast at replying again.

On Sun, Feb 15, 2009 at 04:39:34PM +0100, Michael Niedermayer wrote:
> > The thread_count thing is something that IMHO is a good thing to allow
> > lavc to set in general, 
> 
> why? lavc can just ignore thread_count if it doesnt allow threads or fail
> hard.
> "Editng" thread_count is a permanent thing, think of
> video1, video2, video3 concatenated
> if something in video2 prevents decoding with 2 threads we dont want to
> block video3 from using the number the user requested

Yes, but I don't consider requiring (to refer to a recent thread)
"obscure incantations" to use lavc any good either.
So that leaves ignoring. Do you have an idea how to ignore thread_count
(and use the proper slice flags) when hardware-accelerated
decoding is used, and in a way that works with selecting just the
PIX_FMT via get_format and is not too messy?
I am not particularly interested in learning the details of mpegvideo.c
before I can decide which way might be acceptable.

> > and the slice_flags... Well, I am not sure about
> > the point of them...
> 
> well then rejected (if even the patch author doesnt know why ...)

And to clarify: I meant that I do not know why they are user-settable in the first
place.