[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

[Diego Biurrun]

On Thu, Feb 12, 2009 at 10:26:21AM +0200, Kostya wrote:
> On Thu, Feb 12, 2009 at 12:44:31AM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 11, 2009 at 09:03:35AM +0200, Kostya wrote:
> > > On Mon, Feb 09, 2009 at 05:26:29PM +0100, Michael Niedermayer wrote:
> > > > On Mon, Feb 09, 2009 at 06:29:09PM +0200, Kostya wrote:
> > > > > On Mon, Feb 09, 2009 at 04:55:04PM +0100, Michael Niedermayer wrote:
> > > > > > On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> > > > > [...]
> > > > > > >  
> > > > > > > prefixed a few
> > > > > > 
> > > > > > a few are not all, but anyway its not your job i admit, it was that way
> > > > > > already before you ...
> > > > > > 
> > > > > > you are missing a changelog update
> > > > > > 
> > > > > > besides this if your c code is as fast as what we have and all cases have
> > > > > > been tested and the regression checksums dont change then its ok
> > > > > 
> > > > > Err, what's the way to test it properly?
> > > > 
> > > > swscale-example is one
> > > > mplayer is the second
> > > > libavfilter the third (be carefull with auto inserted scale filters because
> > > > if you test one and 3 are inserted behind your back you might be confused ..)
> > > 
> > > Tested with swscale-example and fixed the bugs in generator. Now it works properly
> > > with all colour depths and full/reduced range.
> > 
> > missing changelog entry
>  
> pick the one you like ;)
>  
> > [...]
> > 
> > > +static void fill_table(uint8_t* table[256], int elemsize, int inc, uint8_t *y_table)
> > 
> > maybe a few const could be added?
> > 
> > ok except these
> 
> Since it's not wholly identical with the old one, regressions are changed too.
> Attached an example of mine obtained at PPC.

Here are mine from my G4, but note that libav regression tests are
failing anyway.  The configuration is --enable-gpl --enable-swscale:

diff -u -w "/tmp/ffmpeg"/tests/libav.regression.ref tests/data/lavf.regression
--- /tmp/ffmpeg/tests/libav.regression.ref      2009-02-07 15:06:23.000000000 +0100
+++ tests/data/lavf.regression  2009-02-13 11:56:12.000000000 +0100
@@ -24,49 +24,49 @@
 af78858062599fcbba049e4a02588a15 *./tests/data/b-libav.mov
 366879 ./tests/data/b-libav.mov
 ./tests/data/b-libav.mov CRC=0x45079dca
-913b6199765b1dcba196706574621c2f *./tests/data/b-libav.dv
+ce752c9e014ca11a0e4bdf1129451756 *./tests/data/b-libav.dv
 3600000 ./tests/data/b-libav.dv
-./tests/data/b-libav.dv CRC=0x7787e173
-8441d11ebee0465f1a672586485f3506 *./tests/data/b-libav.gxf
-805996 ./tests/data/b-libav.gxf
-./tests/data/b-libav.gxf CRC=0x9c06676e
+./tests/data/b-libav.dv CRC=0x645ce571
+0e5458da4fb47555f64cd0e3d54168b8 *./tests/data/b-libav.gxf
+805460 ./tests/data/b-libav.gxf
+./tests/data/b-libav.gxf CRC=0xd8ed3b8b
 66a6584f9e83e8ea3af822a3ba71fbbe *./tests/data/b-libav.nut
 329264 ./tests/data/b-libav.nut
 ./tests/data/b-libav.nut CRC=0x400c29e9
 6f4e64d21325f6721cdbddca2626e5df *./tests/data/b-libav.mkv
 329797 ./tests/data/b-libav.mkv
 ./tests/data/b-libav.mkv CRC=0x400c29e9
-af195c31e8f49de61e3851ccde4c3ebd *./tests/data/b-pbmpipe.pbm
+584f1b68ff3ea3cf48f4126315c9b783 *./tests/data/b-pbmpipe.pbm
 317075 ./tests/data/b-pbmpipe.pbm
-./tests/data/b-pbmpipe.pbm CRC=0x1ac46c70
+./tests/data/b-pbmpipe.pbm CRC=0xdb211a40
 aff140ce80a1c86c1bf54118ad23da7b *./tests/data/b-pgmpipe.pgm
 2534775 ./tests/data/b-pgmpipe.pgm
 ./tests/data/b-pgmpipe.pgm CRC=0x0e82c482
-94939357f0cb9502c474e3b017bd745a *./tests/data/b-ppmpipe.ppm
+06ee5a64ee6e220c2fcf4094e9ad94c8 *./tests/data/b-ppmpipe.ppm
 7603575 ./tests/data/b-ppmpipe.ppm
-./tests/data/b-ppmpipe.ppm CRC=0x80b9c1bc
-b1450712a8dbb81602320d59e40ec3db *./tests/data/b-libav.gif
+./tests/data/b-ppmpipe.ppm CRC=0xc3187dde
+a0ed2b1082402d540edee2cdb53b56e9 *./tests/data/b-libav.gif
 2906382 ./tests/data/b-libav.gif
 b977a4fedff90a79baf70c8e02986820 *./tests/data/b-libav.y4m
 3801810 ./tests/data/b-libav.y4m
 0a6d74b54396884f117669965b57d3b5 *./tests/data/b-libav02.pgm
 ./tests/data/b-libav%02d.pgm CRC=0xc8032eb1
 101391 ./tests/data/b-libav02.pgm
-eb5b4ff1352f952234164ca15bd9d9e8 *./tests/data/b-libav02.ppm
-./tests/data/b-libav%02d.ppm CRC=0x13da003d
+4f339245c654fa3e2c8344278e4befc0 *./tests/data/b-libav02.ppm
+./tests/data/b-libav%02d.ppm CRC=0x1e2be7e3
 304143 ./tests/data/b-libav02.ppm
-419701a0c5b87283176a3cdd648649a7 *./tests/data/b-libav02.bmp
-./tests/data/b-libav%02d.bmp CRC=0x34f4003d
+9f453e4d0602ee5ffb1ab49bda19467c *./tests/data/b-libav02.bmp
+./tests/data/b-libav%02d.bmp CRC=0xf05de7e3
 304182 ./tests/data/b-libav02.bmp
-714379cd2d4dc43b63d7b51c4d60df06 *./tests/data/b-libav02.tga
-./tests/data/b-libav%02d.tga CRC=0x34f4003d
+88387e080a4024b743ae43200c5a9b33 *./tests/data/b-libav02.tga
+./tests/data/b-libav%02d.tga CRC=0xf05de7e3
 304172 ./tests/data/b-libav02.tga
-668be47e39d3b293b36ee4a19650888f *./tests/data/b-libav02.tiff
-./tests/data/b-libav%02d.tiff CRC=0x13da003d
-307140 ./tests/data/b-libav02.tiff
-af9d42ee21fa256dc5ec6b45f0b57f19 *./tests/data/b-libav02.sgi
-./tests/data/b-libav%02d.sgi CRC=0x13da003d
-307753 ./tests/data/b-libav02.sgi
+dae07de74dce93ce290e1602cc8728b8 *./tests/data/b-libav02.tiff
+./tests/data/b-libav%02d.tiff CRC=0x1e2be7e3
+307219 ./tests/data/b-libav02.tiff
+a6e1b850296498e39eea3aa1ced8d7d4 *./tests/data/b-libav02.sgi
+./tests/data/b-libav%02d.sgi CRC=0x1e2be7e3
+309605 ./tests/data/b-libav02.sgi
 8dd3739ea6778335f57fb3e2a28c6453 *./tests/data/b-libav02.jpg
 ./tests/data/b-libav%02d.jpg CRC=0x2e3e4535
 31586 ./tests/data/b-libav02.jpg
@@ -100,23 +100,23 @@
 304128 ./tests/data/b-libav-yuv422p.yuv
 52bb2f530036c657edc512965258d735 *./tests/data/b-libav-yuv444p.yuv
 304128 ./tests/data/b-libav-yuv444p.yuv
-345bf1aff3fa9eba908bb8ebef284346 *./tests/data/b-libav-yuyv422.yuv
+cd761f29085c0bf184093798d8741870 *./tests/data/b-libav-yuyv422.yuv
 304128 ./tests/data/b-libav-yuyv422.yuv
 e2d4633215bc12b933eb733cfbd9c022 *./tests/data/b-libav-yuv410p.yuv
 304128 ./tests/data/b-libav-yuv410p.yuv
 692c12328dce2b5785bd658425660296 *./tests/data/b-libav-yuv411p.yuv
 304128 ./tests/data/b-libav-yuv411p.yuv
-a0b0e086c800ee0b590c2f85bbff5e79 *./tests/data/b-libav-yuvj420p.yuv
+9204e83bc09e39859729a28e60751f1b *./tests/data/b-libav-yuvj420p.yuv
 304128 ./tests/data/b-libav-yuvj420p.yuv
-b365c84c3d3f3a9d6d3a7f942ac68e79 *./tests/data/b-libav-yuvj422p.yuv
+9c7a932ccbea3104046b1a85988a6400 *./tests/data/b-libav-yuvj422p.yuv
 304128 ./tests/data/b-libav-yuvj422p.yuv
 a79eea1bb595f8ede8dad2c82346ce6a *./tests/data/b-libav-yuvj444p.yuv
 304128 ./tests/data/b-libav-yuvj444p.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-rgb24.yuv
+b1d8d08d4e33b3b1449ccfc6b9a292fc *./tests/data/b-libav-rgb24.yuv
 304128 ./tests/data/b-libav-rgb24.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-bgr24.yuv
+b1d8d08d4e33b3b1449ccfc6b9a292fc *./tests/data/b-libav-bgr24.yuv
 304128 ./tests/data/b-libav-bgr24.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-rgb32.yuv
+b1d8d08d4e33b3b1449ccfc6b9a292fc *./tests/data/b-libav-rgb32.yuv
 304128 ./tests/data/b-libav-rgb32.yuv
 8e84e5fb320e57e2e137ba8608394a47 *./tests/data/b-libav-rgb565.yuv
 304128 ./tests/data/b-libav-rgb565.yuv
@@ -124,9 +124,9 @@
 304128 ./tests/data/b-libav-rgb555.yuv
 838958bb95a41057a18bbb647c39ba87 *./tests/data/b-libav-gray.yuv
 304128 ./tests/data/b-libav-gray.yuv
-924f069f4c9ad5beeb7e56f6b701b1a5 *./tests/data/b-libav-monow.yuv
+72c8ffca5303fbc494aaa408e49b0863 *./tests/data/b-libav-monow.yuv
 304128 ./tests/data/b-libav-monow.yuv
-924f069f4c9ad5beeb7e56f6b701b1a5 *./tests/data/b-libav-monob.yuv
+72c8ffca5303fbc494aaa408e49b0863 *./tests/data/b-libav-monob.yuv
 304128 ./tests/data/b-libav-monob.yuv
 ac2c17f1a27d928e8b82f21dbafdd715 *./tests/data/b-libav-yuv440p.yuv
 304128 ./tests/data/b-libav-yuv440p.yuv
make: *** [libavtest] Error 1


Diego