[FFmpeg-devel] [PATCH] Swscale YUV2RGB table generator

[Diego Biurrun]

On Thu, Feb 12, 2009 at 10:26:21AM +0200, Kostya wrote:
> On Thu, Feb 12, 2009 at 12:44:31AM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 11, 2009 at 09:03:35AM +0200, Kostya wrote:
> > > On Mon, Feb 09, 2009 at 05:26:29PM +0100, Michael Niedermayer wrote:
> > > > On Mon, Feb 09, 2009 at 06:29:09PM +0200, Kostya wrote:
> > > > > On Mon, Feb 09, 2009 at 04:55:04PM +0100, Michael Niedermayer wrote:
> > > > > > On Mon, Feb 09, 2009 at 05:38:24PM +0200, Kostya wrote:
> > > > > [...]
> > > > > > >  
> > > > > > > prefixed a few
> > > > > > 
> > > > > > a few are not all, but anyway its not your job i admit, it was that way
> > > > > > already before you ...
> > > > > > 
> > > > > > you are missing a changelog update
> > > > > > 
> > > > > > besides this if your c code is as fast as what we have and all cases have
> > > > > > been tested and the regression checksums dont change then its ok
> > > > > 
> > > > > Err, what's the way to test it properly?
> > > > 
> > > > swscale-example is one
> > > > mplayer is the second
> > > > libavfilter the third (be carefull with auto inserted scale filters because
> > > > if you test one and 3 are inserted behind your back you might be confused ..)
> > > 
> > > Tested with swscale-example and fixed the bugs in generator. Now it works properly
> > > with all colour depths and full/reduced range.
> > 
> > missing changelog entry
>  
> pick the one you like ;)
>  
> > [...]
> > 
> > > +static void fill_table(uint8_t* table[256], int elemsize, int inc, uint8_t *y_table)
> > 
> > maybe a few const could be added?
> > 
> > ok except these
> 
> Since it's not wholly identical with the old one, regressions are changed too.
> Attached an example of mine obtained at PPC.

Here are the results from my K6-III with the following configuration:

--enable-gpl --enable-swscale --enable-xvmc --enable-postproc --enable-avfilter --enable-avfilter-lavf --disable-mmx2 --disable-sse

diff -u -w "/usr/src/ffmpeg"/tests/libav.regression.ref tests/data/lavf.regression
--- /usr/src/ffmpeg/tests/libav.regression.ref  2009-02-07 14:44:37.000000000 +0100
+++ tests/data/lavf.regression  2009-02-13 11:24:45.000000000 +0100
@@ -36,37 +36,37 @@
 6f4e64d21325f6721cdbddca2626e5df *./tests/data/b-libav.mkv
 329797 ./tests/data/b-libav.mkv
 ./tests/data/b-libav.mkv CRC=0x400c29e9
-af195c31e8f49de61e3851ccde4c3ebd *./tests/data/b-pbmpipe.pbm
+1008f5b7487c76314772e1346e0bd478 *./tests/data/b-pbmpipe.pbm
 317075 ./tests/data/b-pbmpipe.pbm
-./tests/data/b-pbmpipe.pbm CRC=0x1ac46c70
+./tests/data/b-pbmpipe.pbm CRC=0x806e17d8
 aff140ce80a1c86c1bf54118ad23da7b *./tests/data/b-pgmpipe.pgm
 2534775 ./tests/data/b-pgmpipe.pgm
 ./tests/data/b-pgmpipe.pgm CRC=0x0e82c482
-94939357f0cb9502c474e3b017bd745a *./tests/data/b-ppmpipe.ppm
+9169b1f1ca56f01a6e1f5041572aa1d4 *./tests/data/b-ppmpipe.ppm
 7603575 ./tests/data/b-ppmpipe.ppm
-./tests/data/b-ppmpipe.ppm CRC=0x80b9c1bc
-b1450712a8dbb81602320d59e40ec3db *./tests/data/b-libav.gif
+./tests/data/b-ppmpipe.ppm CRC=0x79bd6ce6
+6ac80e7d403b715fd4da75c01d464d5e *./tests/data/b-libav.gif
 2906382 ./tests/data/b-libav.gif
 b977a4fedff90a79baf70c8e02986820 *./tests/data/b-libav.y4m
 3801810 ./tests/data/b-libav.y4m
 0a6d74b54396884f117669965b57d3b5 *./tests/data/b-libav02.pgm
 ./tests/data/b-libav%02d.pgm CRC=0xc8032eb1
 101391 ./tests/data/b-libav02.pgm
-eb5b4ff1352f952234164ca15bd9d9e8 *./tests/data/b-libav02.ppm
-./tests/data/b-libav%02d.ppm CRC=0x13da003d
+dbe42bd8d9ca0acbd2673bd739705f0f *./tests/data/b-libav02.ppm
+./tests/data/b-libav%02d.ppm CRC=0x6f775c0d
 304143 ./tests/data/b-libav02.ppm
-419701a0c5b87283176a3cdd648649a7 *./tests/data/b-libav02.bmp
-./tests/data/b-libav%02d.bmp CRC=0x34f4003d
+da84c82fe290a004b45c6e1fbc389681 *./tests/data/b-libav02.bmp
+./tests/data/b-libav%02d.bmp CRC=0xc0775c0d
 304182 ./tests/data/b-libav02.bmp
-714379cd2d4dc43b63d7b51c4d60df06 *./tests/data/b-libav02.tga
-./tests/data/b-libav%02d.tga CRC=0x34f4003d
+7b8cb80f2518af66fd87ec94a6e27ad7 *./tests/data/b-libav02.tga
+./tests/data/b-libav%02d.tga CRC=0xc0775c0d
 304172 ./tests/data/b-libav02.tga
-668be47e39d3b293b36ee4a19650888f *./tests/data/b-libav02.tiff
-./tests/data/b-libav%02d.tiff CRC=0x13da003d
-307140 ./tests/data/b-libav02.tiff
-af9d42ee21fa256dc5ec6b45f0b57f19 *./tests/data/b-libav02.sgi
-./tests/data/b-libav%02d.sgi CRC=0x13da003d
-307753 ./tests/data/b-libav02.sgi
+a61d4116ee455880c9b788b6086a8ffa *./tests/data/b-libav02.tiff
+./tests/data/b-libav%02d.tiff CRC=0x6f775c0d
+307144 ./tests/data/b-libav02.tiff
+7e60222bb54dcd97b3300b7353b69c5a *./tests/data/b-libav02.sgi
+./tests/data/b-libav%02d.sgi CRC=0x6f775c0d
+308068 ./tests/data/b-libav02.sgi
 8dd3739ea6778335f57fb3e2a28c6453 *./tests/data/b-libav02.jpg
 ./tests/data/b-libav%02d.jpg CRC=0x2e3e4535
 31586 ./tests/data/b-libav02.jpg
@@ -112,21 +112,21 @@
 304128 ./tests/data/b-libav-yuvj422p.yuv
 a79eea1bb595f8ede8dad2c82346ce6a *./tests/data/b-libav-yuvj444p.yuv
 304128 ./tests/data/b-libav-yuvj444p.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-rgb24.yuv
+7c1108633b0fef1aff5637fe70e74d0c *./tests/data/b-libav-rgb24.yuv
 304128 ./tests/data/b-libav-rgb24.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-bgr24.yuv
+7c1108633b0fef1aff5637fe70e74d0c *./tests/data/b-libav-bgr24.yuv
 304128 ./tests/data/b-libav-bgr24.yuv
-20dc18820fb75d5b3c446aae2f3ebf5a *./tests/data/b-libav-rgb32.yuv
+7c1108633b0fef1aff5637fe70e74d0c *./tests/data/b-libav-rgb32.yuv
 304128 ./tests/data/b-libav-rgb32.yuv
-8e84e5fb320e57e2e137ba8608394a47 *./tests/data/b-libav-rgb565.yuv
+d86c3fa21db8b4eaf3efb66b7b245e46 *./tests/data/b-libav-rgb565.yuv
 304128 ./tests/data/b-libav-rgb565.yuv
-9b74239ec2e35e70c669a2a6ad550f8c *./tests/data/b-libav-rgb555.yuv
+64d733888d3f17513383453fae238fdc *./tests/data/b-libav-rgb555.yuv
 304128 ./tests/data/b-libav-rgb555.yuv
 838958bb95a41057a18bbb647c39ba87 *./tests/data/b-libav-gray.yuv
 304128 ./tests/data/b-libav-gray.yuv
-924f069f4c9ad5beeb7e56f6b701b1a5 *./tests/data/b-libav-monow.yuv
+c7c9d2b2926e1677c27bd7df89f53073 *./tests/data/b-libav-monow.yuv
 304128 ./tests/data/b-libav-monow.yuv
-924f069f4c9ad5beeb7e56f6b701b1a5 *./tests/data/b-libav-monob.yuv
+c7c9d2b2926e1677c27bd7df89f53073 *./tests/data/b-libav-monob.yuv
 304128 ./tests/data/b-libav-monob.yuv
 ac2c17f1a27d928e8b82f21dbafdd715 *./tests/data/b-libav-yuv440p.yuv
 304128 ./tests/data/b-libav-yuv440p.yuv
make: *** [libavtest] Error 1


Diego