[FFmpeg-devel] Process (Was: [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4))

Michael Niedermayer michaelni
Tue Feb 10 22:57:47 CET 2009

On Tue, Feb 10, 2009 at 01:31:55PM +0100, Gwenole Beauchesne wrote:
> On Tue, 10 Feb 2009, Michael Niedermayer wrote:
> > What my question was, was if you agree about my technical suggestions to
> > improve your patch or if you had some better ideas.
> You are not asking me to improve my patch, but to write another patch to 
> fix previous mistakes, or would you accept my new patch for VA API + the 
> suggested FFmpeg API combined at once? I pretty doubt so.

let me say it one more time, NO factorizeable code (that we notice to be so)
goes in svn, either someone factorizes it or it stays out.

> When I receive a patch and it doesn't fit the current architecture of my 
> projects, I do fix it myself because I failed to think correctly in the 
> first place and missed their approach.

how many patches do you receive per month? more than we per day?

> If I don't understand their 
> approach, I ask. Along the way, I also arrange their patch to fit the new 
> fixed architecture + fixing cosmetics at the same time. I am not an 
> idealist, it's just that I think we learn better of our own mistakes if we 
> manage to fix them ourselves + I don't want to bother others with 
> futilities (cosmetics). And I won't ask them either to implement something 
> I only have in my mind. Because the time I would spend explaining to them 
> in details what I intend to do is usually equivalent to what I would 
> actually spend in writing the code...

This approuch fails in various ways, first because you change code that
you arent the author of you
1. piss the author off
2. make mistakes that the author would not have made.
3. require more time.
and because you dont bother explaining anything to the author you
1. make it hard for him to maintain the code in the future
2. prevent healthy discussion and teamwork


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090210/6f5ff732/attachment.pgp>

More information about the ffmpeg-devel mailing list