[FFmpeg-devel] Process (Was: [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4))

[Gwenole Beauchesne]

On Tue, 10 Feb 2009, Michael Niedermayer wrote:

> What my question was, was if you agree about my technical suggestions to
> improve your patch or if you had some better ideas.

You are not asking me to improve my patch, but to write another patch to 
fix previous mistakes, or would you accept my new patch for VA API + the 
suggested FFmpeg API combined at once? I pretty doubt so.

IOW, it's not a functional improvement either. i.e. it won't make it more 
functional than it is currently.

> if your patch would have been submitted a month before nvidias then they
> now would likely be in your position.

And I still maintain this wouldn't be their role either. I would have the 
same complaint. ;-)

>> Because you are actually the one who know more the surrounding code and
>> has the best overview of the code. So, you are a reference, if you
>> accepted a patch, then it was a correct practise and incentive to others
>> to operate the same.
>
> humans make mistakes, we should learn out of them not not repeat them
> you ask me to repeat my mistake and accept your patch with the same issues
> as previous ones.

So, you think its a better attitude to request others fix your mistakes?

When I receive a patch and it doesn't fit the current architecture of my 
projects, I do fix it myself because I failed to think correctly in the 
first place and missed their approach. If I don't understand their 
approach, I ask. Along the way, I also arrange their patch to fit the new 
fixed architecture + fixing cosmetics at the same time. I am not an 
idealist, it's just that I think we learn better of our own mistakes if we 
manage to fix them ourselves + I don't want to bother others with 
futilities (cosmetics). And I won't ask them either to implement something 
I only have in my mind. Because the time I would spend explaining to them 
in details what I intend to do is usually equivalent to what I would 
actually spend in writing the code...