[FFmpeg-devel] [PATCH][7/8] Add VA API accelerated H.264 decoding (take 4)

[Diego Biurrun]

On Tue, Feb 10, 2009 at 11:31:49AM +0100, Gwenole Beauchesne wrote:
> 
> On Mon, 9 Feb 2009, Diego Biurrun wrote:
> 
> > You also have the bad luck of having modeled your work on xvmc (or on
> > vdpau, which is modeled on xvmc), one of the cruftiest parts of FFmpeg.
> > It's not your fault, it's bad luck, but it does not make the issues go
> > away.  We just start noticing them now that this hornet's nest is
> > stirred...
> 
> Then please add notes that this is incorrect practise. I think anyone 
> would start reading existing code to base their own work off it, get 
> inspiration of good practise (assuming it was since it was committed).

Like in the attached patch?  (possibly extended to vdpau)

> Whyt not add a file that would list good practise for this or that 
> "use-case". e.g. "If you want to implement a VO see XXX", "if you want to 
> implement a new codec that does X or Y, see Y". That surely would help. 
> And while you are at the release process, it's probably also the good 
> occasion to review what is good or bad practise in the current code and 
> invite people (current maintainers) to improve existing code? Though, in 
> practise, that's a complex task too...
> 
> WDYT?

Patches welcome.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvmc.diff
Type: text/x-diff
Size: 840 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090210/f8e9fdce/attachment.diff>