[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Ronald S. Bultje]

Hi,

On Wed, Feb 4, 2009 at 12:23 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> why dont you put the comments before the vars like AVCodecContext

Ok, will do, will take a short while, though.

>> >> -    void *cur_tx;
>> >> +    void *cur_tx;                     /**< stream for last packet */
>> >
>> > where is the typedef for type stream? there is none? then what is a stream?
>> > this is a void* so no way to know ...
>>
>> Crappy comment, I rewrote it so it's clear what the variable is. I
>> already know what your next question will be ("what is
>> RTSPStream->tx_ctx?"), but I think that's relatively clearly
>> documented.
>
> you mean "RTP/RDT parse context"
> i dunno, doesnt sound clear to me, besides you could mention this i the
> comment of cur_tx, its always better to say things instead of refereing
> to some other place if its just 2-3 words.
> besides why is it void*?

Its type depends on transport (enum RTSPTransport). If transport is
RTP, it's a RTPDemuxContext, if transport is RDT, it's a
RDTDemuxContext.

I think this is safe, transport is only set once, and tx_ctx is
allocated after that and we always check the transport field before
calling any function with tx_ctx in rtsp.c. I'll add a comment about
this also if you wish.

Ronald