[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Michael Niedermayer]

On Wed, Feb 04, 2009 at 12:43:28PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Feb 4, 2009 at 12:23 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > why dont you put the comments before the vars like AVCodecContext
> 
> Ok, will do, will take a short while, though.
> 
> >> >> -    void *cur_tx;
> >> >> +    void *cur_tx;                     /**< stream for last packet */
> >> >
> >> > where is the typedef for type stream? there is none? then what is a stream?
> >> > this is a void* so no way to know ...
> >>
> >> Crappy comment, I rewrote it so it's clear what the variable is. I
> >> already know what your next question will be ("what is
> >> RTSPStream->tx_ctx?"), but I think that's relatively clearly
> >> documented.
> >
> > you mean "RTP/RDT parse context"
> > i dunno, doesnt sound clear to me, besides you could mention this i the
> > comment of cur_tx, its always better to say things instead of refereing
> > to some other place if its just 2-3 words.
> > besides why is it void*?
> 
> Its type depends on transport (enum RTSPTransport). If transport is
> RTP, it's a RTPDemuxContext, if transport is RDT, it's a
> RDTDemuxContext.

transport_priv_ctx seems like a better name ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090204/fa3cdc36/attachment.pgp>