[FFmpeg-devel] build warning in dsputil.c

[Diego Biurrun]

On Mon, Jan 26, 2009 at 04:36:48PM +0100, Diego Biurrun wrote:
> On Mon, Jan 26, 2009 at 04:35:39PM +0100, Benoit Fouet wrote:
> > On 01/26/2009 04:17 PM, Diego Biurrun wrote:
> > > On Fri, Jan 23, 2009 at 02:09:22PM +0100, Aurelien Jacobs wrote:
> > >   
> > >> Diego Biurrun wrote:
> > >>
> > >>> On Thu, Jan 22, 2009 at 09:18:52PM -0500, Justin Ruggles wrote:
> > >>>       
> > >>>> I get:
> > >>>> libavcodec/dsputil.c:4500:5: warning: "CONFIG_H264_ENCODER" is not defined
> > >>>>
> > >>>> This seems related to the recent build system changes. Maybe this one
> > >>>> was overlooked?
> > >>>>         
> > >>> No, it's due to the fact that we do not have a H.264 encoder, but
> > >>> some fragments of H.264 encoder code lying around.
> > >>> Since this particular case is just one silly line:
> > >>>
> > >>>     ff_h264dspenc_init(c,avctx);
> > >>>
> > >>> I vote for just removing it.  In the unlikely case that somebody decides
> > >>> to work on an H.264 encoder in the future, this is trivial to restore.
> > >>>       
> > >> This indeed sounds like a sane solution.
> > >>     
> > >
> > > I'll apply $attached on Wednesday.
> > 
> > missing patch ?
> 
> /* no comment */

Applied.

Diego