[FFmpeg-devel] [PATCH] RTSP-MS 9/15: add interleave property to the TCP transport line of the SETUP request

[Ronald S. Bultje]

Hi,

On Sun, Feb 1, 2009 at 8:12 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
> Ronald S. Bultje wrote:
>> On Sat, Jan 31, 2009 at 11:19 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
>>> Ronald S. Bultje wrote:
>>>> OK, RTP accepts with or without unicast, Real only without and WMS
>>>> only with. UDP currently does unicast except for Real, so I added the
>>>> same case for TCP as well. Interleave is supported by all and is thus
>>>> outside of any conditional clause.
>>> It shouldn't work -> unicast means udp, interleaved means tcp (well any
>>> other transport in theory but right now just tcp is supported and
>>> specified in rfcs)
>>
>> Odd, I guess "unexpected" fields are just discarded then, apparently
>> except by WMS or Real (gosh, what a surprise :-) ), which either wants
>> unicast for both TCP *and* UDP (WMS) or doesn't want them at all
>> (Real), neither of which is correct.
>>
>> Attached patch (probably?) does the correct thing. Sorry it has to be
>> this way, but MS/TCP really does require the unicast property in the
>> TCP transport, it fails without. All I'm doing is try to make it work
>> in ffplay. :-).
>
> this one is the one I like, please apply ^^

Applied, thanks!

Ronald