[FFmpeg-devel] Google Summer of Code participation

Thilo Borgmann thilo.borgmann
Tue Apr 7 14:51:08 CEST 2009



Ronald S. Bultje schrieb:
> Not yet done...
>
> --- a/libavcodec/sp5xdec.c
> +++ b/libavcodec/sp5xdec.c
> [..]
> @@ -89,7 +92,9 @@ static int sp5x_decode_frame(AVCodecContext *avctx,
>      recoded[j++] = 0xD9;
>
>      avctx->flags &= ~CODEC_FLAG_EMU_EDGE;
> -    i = ff_mjpeg_decode_frame(avctx, data, data_size, recoded, j);
> +    avpkt_recoded.data = recoded;
> +    avpkt_recoded.size = j;
> +    i = ff_mjpeg_decode_frame(avctx, data, data_size, &avpkt_recoded);
>
>      av_free(recoded);
>
> That leaves some fields uninitialized, you should use av_init_packet()
> here also.
>
> [..]
>
> Also, is there a patch for ffplay.c/ffmpeg.c? I can do it myself but I
> wasn't sure if you submitted it already and I missed it...
>
>
>   
OK, added the init function in revision 7.

I've an update for these files, yes, but I think it makes sense to put 
this in a seperate patch, doesn't it?

TB
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tb.changedAVCodec.rev7.patch
Type: text/x-patch
Size: 98629 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090407/3b198a87/attachment.bin>



More information about the ffmpeg-devel mailing list