[FFmpeg-devel] Google Summer of Code participation

[Michael Niedermayer]

On Tue, Apr 07, 2009 at 02:51:08PM +0200, Thilo Borgmann wrote:
>
>
> Ronald S. Bultje schrieb:
>> Not yet done...
>>
>> --- a/libavcodec/sp5xdec.c
>> +++ b/libavcodec/sp5xdec.c
>> [..]
>> @@ -89,7 +92,9 @@ static int sp5x_decode_frame(AVCodecContext *avctx,
>>      recoded[j++] = 0xD9;
>>
>>      avctx->flags &= ~CODEC_FLAG_EMU_EDGE;
>> -    i = ff_mjpeg_decode_frame(avctx, data, data_size, recoded, j);
>> +    avpkt_recoded.data = recoded;
>> +    avpkt_recoded.size = j;
>> +    i = ff_mjpeg_decode_frame(avctx, data, data_size, &avpkt_recoded);
>>
>>      av_free(recoded);
>>
>> That leaves some fields uninitialized, you should use av_init_packet()
>> here also.
>>
>> [..]
>>
>> Also, is there a patch for ffplay.c/ffmpeg.c? I can do it myself but I
>> wasn't sure if you submitted it already and I missed it...
>>
>>
>>   
> OK, added the init function in revision 7.
>
> I've an update for these files, yes, but I think it makes sense to put this 
> in a seperate patch, doesn't it?

yes


[...]
> @@ -89,7 +92,10 @@ static int sp5x_decode_frame(AVCodecContext *avctx,
>      recoded[j++] = 0xD9;
>  
>      avctx->flags &= ~CODEC_FLAG_EMU_EDGE;
> -    i = ff_mjpeg_decode_frame(avctx, data, data_size, recoded, j);
> +	av_init_packet(&avpkt_recoded);

tabs


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090407/c38abf64/attachment.pgp>