[FFmpeg-devel] Realmedia patch

Luca Abeni lucabe72
Wed Sep 17 23:52:36 CEST 2008


Ronald S. Bultje wrote:
[...]
>>>> Why is only ff_rdt_subscribe_rule2() under the "RTSP_TRANSPORT_RDT" case?
>>>> Isn't ff_rdt_subscribe_rule() RDT specific too? (otherwise, "ff_rdt_" is
>>>> misleading).
>>> I'll rename it ff_real_() in the end. Do you want that before or after
>>> all other patches? (My plan was after.)
>> I think you can do it after. I was just surprised by the position of the
>> "if()", but if this is intended I have no problems with it.
> 
> It's intended. It's basically selection of the substream in RDT
> (loading of the correct OpaqueData). The rest (actual subscription) is
> in the whole function, which is already under if (server == REAL).

Ah, ok; this is the detail I missed.


> So yes, it's intended. I'll commit in 2-3 days as normal.

Ok for me.


			Luca




More information about the ffmpeg-devel mailing list