[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Wed, Sep 17, 2008 at 11:11:19PM +0200, Luca Abeni wrote:
> Hi Ronald,
> 
> Ronald S. Bultje wrote:
> [...]
> > New patch for actual change attached.
> 
> This looks ok, except 3 details:
> 
> > Index: ffmpeg-svn/libavformat/rtsp.c
> > ===================================================================
> > --- ffmpeg-svn.orig/libavformat/rtsp.c	2008-09-14 11:09:54.000000000 -0400
> > +++ ffmpeg-svn/libavformat/rtsp.c	2008-09-14 11:24:26.000000000 -0400
> > @@ -49,6 +49,12 @@
> >      RTSP_SERVER_LAST
> >  };
> >  
> > +enum RTSPTransport {
> > +    RTSP_TRANSPORT_RTP, /*< Standard-compliant RTP packet */
> > +    RTSP_TRANSPORT_RDT, /*< Real Data Packet */
> > +    RTSP_TRANSPORT_LAST
> > +};
> 
> The comments here are confusing, talking about "RTP packet" and
> "Real Data Packet" when they are related to the protocol...
> The correct comments would be "RTP protocol" and "RDT protocol",
> but such comments would be useless. I do not know what's the policy
> here (a "RTP protocol" comment for RTSP_TRANSPORT_RTP looks completely
> redundant...), someone else should comment on this (otherwise, I'd say
> to just remove the comment).

Id also say remove redundant comments.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080918/45750e54/attachment.pgp>