[FFmpeg-devel] [PATCH] libx264: support for BUILD >= 63

Jason Garrett-Glaser darkshikari
Tue Sep 16 10:17:47 CEST 2008

> While ifdeffery in libx264.c doesn't look like a good idea due to the
> libx264 API instability, I think we could at least provide a check in
> the configure script to disable libx264 if the detected version isn't
> valid, looks nicer towards the user.

Bad idea--if the user explicitly enables something, and that thing
fails, configure should fail outright, not disable it.  It does for
all other external libs, so it should for x264, too.

> And while we're at it we could assert(X264_BUILD == x264_build()) in
> the init code (assuming that function is implemented).

Bad idea too; x264 can and does make API modifications that do not
break backwards compatibility.

Dark Shikari

More information about the ffmpeg-devel mailing list