[FFmpeg-devel] [PATCH] libx264: support for BUILD >= 63
Tue Sep 16 09:28:41 CEST 2008
On date Monday 2008-09-15 15:07:14 -0400, Daniel G. Taylor encoded:
> On Mon, 2008-09-15 at 22:55 +0400, Andrew Savchenko wrote:
> > Hi,
> > On Monday 15 September 2008 22:41, Daniel G. Taylor wrote:
> > [...]
> > > The patch looks okay but it mandates that ffmpeg requires the
> > > newer libx264 from this point on, so maybe a library version
> > > check is in order? What's the normal ffmpeg policy on this?
> > Perhaps, it is to projects using ffmeg? At least mplayer do version
> > check for x264 in configure script.
> I think I have to agree with Baptiste here because there is no API
> change in libav* and if you are calling ffmpeg as an external program
> there is no change either. This shouldn't affect you at all, and you
> should be checking the libav* versions if you are using them anyway. A
> change there implies potential breakage.
> That said if you'd like to it's a simple #if X264_BUILD < 64 check to
> add to the file.
While ifdeffery in libx264.c doesn't look like a good idea due to the
libx264 API instability, I think we could at least provide a check in
the configure script to disable libx264 if the detected version isn't
valid, looks nicer towards the user.
And while we're at it we could assert(X264_BUILD == x264_build()) in
the init code (assuming that function is implemented).
FFmpeg = Fast and Freak Mean Porno Exploitable Gangster
More information about the ffmpeg-devel