[FFmpeg-devel] [PATCH] Define cmdline_program_name and use it in show_help

[Stefano Sabatini]

On date Monday 2008-10-27 13:46:24 +0100, Luca Abeni encoded:
> Hi all,
> 
> Aurelien Jacobs wrote:
> [...]
> >>> Index: ffmpeg.c
> >>> ===================================================================
> >>> --- ffmpeg.c	(revision 15712)
> >>> +++ ffmpeg.c	(working copy)
> >>> @@ -71,6 +71,7 @@
> >>>  #undef exit
> >>>  
> >>>  const char program_name[] = "FFmpeg";
> >>> +const char* cmdline_program_name = NULL;
> >>>   
> >> why is it not static ? btw, I'd prefer char *foo to char* foo, but maybe
> >> that's just me...
> > 
> > I also prefer char *foo.
> > And no need to initialize it to NULL.

OK.
 
> Maybe this is a stupid question, but... Why using a global variable instead
> of passing argv[0] as an argument to show_help() (in ffplay.c and ffmpeg.c)?

For consistency with program_name, no strong opinion on this.

And yes the variable should be declared static as well program_name
and program_birthyear, patch will follow for that.

Regards.
-- 
FFmpeg = Faboulous & Free Meaningful Patchable Ecstatic Gem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: define-cmdline-program-name-01.patch
Type: text/x-diff
Size: 2796 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081027/30e8e806/attachment.patch>