[FFmpeg-devel] [PATCH] Define cmdline_program_name and use it in show_help

[Luca Abeni]

Hi all,

Aurelien Jacobs wrote:
[...]
>>> Index: ffmpeg.c
>>> ===================================================================
>>> --- ffmpeg.c	(revision 15712)
>>> +++ ffmpeg.c	(working copy)
>>> @@ -71,6 +71,7 @@
>>>  #undef exit
>>>  
>>>  const char program_name[] = "FFmpeg";
>>> +const char* cmdline_program_name = NULL;
>>>   
>> why is it not static ? btw, I'd prefer char *foo to char* foo, but maybe
>> that's just me...
> 
> I also prefer char *foo.
> And no need to initialize it to NULL.

Maybe this is a stupid question, but... Why using a global variable instead
of passing argv[0] as an argument to show_help() (in ffplay.c and ffmpeg.c)?


				Luca