[FFmpeg-devel] Problem with cross compilation / need?guidance?for patch submission

[Diego Biurrun]

On Sun, Oct 12, 2008 at 05:53:22PM +0000, Edouard Gomez wrote:
> On Sun, 12 Oct 2008 19:38:15 +0200, Diego Biurrun wrote:
> >> To put it simply, the ffmpeg build system is at fault because it
> >> imposes the std=c99 to headers that were never thought to be compiled
> >> like that. Why fix external headers ? Isn't the responsability of the
> >> includer to use the headers correctly ?
> > 
> > It's not quite like that.  All you need to do is add a single underscore
> > to one word in one header and all your problems will go away...
> 
> True for libfaac. Not quite the same for libmp3lame
> because  _cdecl must be changed into __cdecl. Touching
> that can break other compilers.

Which compilers can break?

> > Fixes need to be done in the correct place so that they reach the
> > maximum number of people and need not be redone everywhere.  Yes, this
> > sometimes puts an extra burden on the bug fixer, in this case you, but
> > it is the better and more work-efficient strategy in the long run.
> 
> Sure. I totaly agree.
> 
> But you could help a little ;-)

What do you want me to do?  I cannot commit to FAAC...

Diego