[FFmpeg-devel] [PATCH] FLAC timestamp

Justin Ruggles justin.ruggles
Wed Nov 19 12:16:12 CET 2008

Andreas ?man wrote:
> Diego Biurrun skrev:
>> On Wed, Nov 19, 2008 at 10:42:24AM +0100, Yvan Labadie wrote:
>>> I join a patch if it can help!
>> Send a unified diff please.
> May I also suggest that a FLAC format demuxer should
> reside in a file of its own?

Yes, definitely.  It could also contain more than just setting the
bitrate.  Ideally, the decoder would be revised so that it does not have
to handle the header, including any metadata.  The demuxer would read
the whole header and set the extradata.

Regarding the patch, it doesn't take into account that the number of
samples can be 0, indicating that it is unknown.  The patch assumes that
seeking can be done, which is not always true.  Also, it contains tabs.


More information about the ffmpeg-devel mailing list