[FFmpeg-devel] [PATCH] convert fdct_mmx.c to plain asm

Michael Niedermayer michaelni
Thu Nov 13 20:11:25 CET 2008

On Thu, Nov 13, 2008 at 10:39:37AM -0800, Baptiste Coudurier wrote:
> Hi Michael,
> Michael Niedermayer wrote:
> > On Wed, Nov 12, 2008 at 06:54:23PM -0800, Baptiste Coudurier wrote:
> >> Hi
> >>
> >> $subject, I hope I did not mess up.
> > 
> > ok, if its output didnt change
> Yeah, it is obvious. No other comment ?

I have many but they dont belong in this patch :)
like not using "r" but MANGLE() to prevent slow GOT indirection,
and to turn the asm parts into just parts of a single asm() instead of
3 asm()

> Like a better way to use the macro, I find it a bit ugly.

#define SHIFT_FRW_COL_STR "3"
should work to avoid S()

> Is fulltest sufficient ? dct-test too ? Just to ensure something didn't
> slip in, the process was painful.

dct-test would probably be a good idea as it should test MMX&MMX2 
it seems to be missing an entry for ff_fdct_sse2() though

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081113/90a6e9ca/attachment.pgp>

More information about the ffmpeg-devel mailing list