[FFmpeg-devel] [PATCH] convert fdct_mmx.c to plain asm

Baptiste Coudurier baptiste.coudurier
Thu Nov 13 20:55:14 CET 2008

Michael Niedermayer wrote:
> On Thu, Nov 13, 2008 at 10:39:37AM -0800, Baptiste Coudurier wrote:
>> Hi Michael,
>> Michael Niedermayer wrote:
>>> On Wed, Nov 12, 2008 at 06:54:23PM -0800, Baptiste Coudurier wrote:
>>>> Hi
>>>> $subject, I hope I did not mess up.
>>> ok, if its output didnt change
>> Yeah, it is obvious. No other comment ?
> I have many but they dont belong in this patch :)
> like not using "r" but MANGLE() to prevent slow GOT indirection,
> and to turn the asm parts into just parts of a single asm() instead of
> 3 asm()

Humm, I'll still let you find the best for these kinds of things :>

>> Like a better way to use the macro, I find it a bit ugly.
> #define SHIFT_FRW_COL_STR "3"
> should work to avoid S()

Yes, I tried that, however some other macros use this as a number, not a
string :/

>> Is fulltest sufficient ? dct-test too ? Just to ensure something didn't
>> slip in, the process was painful.
> dct-test would probably be a good idea as it should test MMX&MMX2 
> it seems to be missing an entry for ff_fdct_sse2() though


Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no

More information about the ffmpeg-devel mailing list