[FFmpeg-devel] [PATCH] Cleaner parity checking code in mlp_parser.c

Måns Rullgård mans
Wed Jun 25 12:33:21 CEST 2008

The Wanderer wrote:
> Ramiro Polla wrote:
>> Ramiro Polla wrote:
>>> Then what about your original idea on that thread? A -1 in there
>>> already helps a bit in understanding the code is not only dealing
>>> with substream headers.
>> And here's a patch for the Ministry of English Composition to clarify
>>  the comment about the code.
>> -        // First nibble of a frame is a parity check of the first few
>> +        /* The first nibble of a frame is a parity check of the 4-byte
>> +         * access unit header and all the 2 or 4 byte substream headers. */
> This has both "4-byte" (hyphenated) and "2 or 4 byte" (non-hyphenated);
> that should be made consistent, either by saying "4 byte" or "2- or
> 4-byte". I am of the school of thought which says that the latter is
> more correct, but given Diego's past decisions on hyphenation he may
> well disagree.

Hyphenated is correct.  Diego has no say in this matter.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list