[FFmpeg-devel] [PATCH] Cleaner parity checking code in mlp_parser.c

Michael Niedermayer michaelni
Wed Jun 25 04:24:03 CEST 2008

On Wed, Jun 25, 2008 at 12:45:26AM +0100, Ramiro Polla wrote:
> Michael Niedermayer wrote:
>> On Tue, Jun 24, 2008 at 08:48:08PM +0100, Ramiro Polla wrote:
>>> Hello,
>>> In http://article.gmane.org/gmane.comp.video.ffmpeg.devel/59805 Michael 
>>> suggested a way to minimize the code that does parity checking on 
>>> mlp_parser.c. This leads to the code being harder to understand.
>>> The for() loop deals with the substream headers, and the smaller code 
>>> parity checked the access unit header in the same loop. It is confusing 
>>> since it looks like the loop is only doing the parity check on the 
>>> substream headers, and not on the access unit header. It takes closer 
>>> inspection to see that the access unit header is also being checked.
>>> Is attached patch ok to desimplify the code to make it easier to 
>>> understand?
>> iam slightly against the patch
> Then what about your original idea on that thread? A -1 in there already 
> helps a bit in understanding the code is not only dealing with substream 
> headers.

Well i better ok this bikeshed or you will waste more time on it.
so, patch ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/0d9d19d2/attachment.pgp>

More information about the ffmpeg-devel mailing list