[FFmpeg-devel] [PATCH] AAC decoder

Robert Swain robert.swain
Fri Jun 13 14:47:29 CEST 2008


2008/6/12 Michael Niedermayer <michaelni at gmx.at>:
> On Tue, Jun 03, 2008 at 01:26:55AM +0100, Robert Swain wrote:
>> 2008/6/2 Robert Swain <robert.swain at gmail.com>:
>> > You'll be happy to know that I'm working on flattening the channel element
>> > structs (sce_struct, cpe_struct, cc_struct) into one (che_struct). When I
>> > submit the patch, I expect it will take an iteration or two to be clean
>> > enough to commit but it has simplified a lot of the code so far. :) There
>> > will also be some considerations about whether to dynamically allocate some
>> > things if they're too large to be allocated with every channel element.
>>
>> See attached. It's a rather large patch and I tried to make it clean
>> (not affecting indentation, etc. as I went along) but maybe you will
>> want it to be split into a number of commits somehow. I don't know
>> whether it will be particularly beneficial but the simplifications
>> resulting from the changes to the structs could be committed
>> separately. It's been tested with stereo and 5.1 files and seems to be
>> working fine. Comments welcome.
>
> Id like it split in a number of patches first.
> * changing the 4 different structs to 1 array of the same struct
> * code simplifications
> * indention fixup to otherwise unchanged lines
>
> being a possibility

See attached.

Note that I ordered the elements of the che_struct such that the
cpe_struct code didn't need to be changed until removal of cpe_struct
was desirable. I hope these are OK. :)

Thanks,
Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-code-necessary-to-switch-to-a-generic-channel-el.patch
Type: text/x-patch
Size: 1314 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002--Switch-to-using-che_struct-in-program_config_struc.patch
Type: text/x-patch
Size: 16156 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Switch-mixdown-code-to-use-che_struct.patch
Type: text/x-patch
Size: 6181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Make-remaining-code-that-uses-cpe_struct-use-che_str.patch
Type: text/x-patch
Size: 1804 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Remove-unused-code.patch
Type: text/x-patch
Size: 1632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Make-code-simplifications-enabled-by-previous-commit.patch
Type: text/x-patch
Size: 6382 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Cosmetics.patch
Type: text/x-patch
Size: 1862 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/efb30085/attachment-0006.bin>



More information about the ffmpeg-devel mailing list