[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Diego Biurrun]

On Thu, Jan 03, 2008 at 11:02:11AM +0100, Luca Abeni wrote:
> 
> Aurelien Jacobs wrote:
> [...]
> >>>  OBJS-$(CONFIG_RTP_MUXER)                 += rtp.o rtp_h264.o rtp_mpv.o rtp_aac.o
> >>> -OBJS-$(CONFIG_RTSP_DEMUXER)              += rtsp.o
> >>> -OBJS-$(CONFIG_SDP_DEMUXER)               += rtsp.o
> >>> +OBJS-$(CONFIG_SDP_DEMUXER)               += rtsp.o rtp.o rtp_h264.o rtp_mpv.o rtp_aac.o
> >> Umm, yes, your patch makes the RTSP demuxer depend on the SDP demuxer,
> >> but still I think we should keep that line here.
> > 
> > I agree we should keep the RTSP line here.
> > Moreover, this still seems to be a dependency mess...
> > I feel there is a need for file splitting here (especially rtp.c).
> > Maybe I will try to have a deeper look at it.
> 
> I was going to apply my patch (with the change suggested by Diego), but 
> after reading your doubts I prefer to wait for your ok too: can I commit 
> the first patch, or there is a better approach to fix the problem? 
> Should I rewrite the second patch splitting rtp.c in rtp.c, rtpenc.c and 
> rtpdec.c?

I would say start by applying your patches, especially the first one.
Splitting the files is the preferable long-term solution, but it can
still be done later.  If you want to try your hand at refactoring rtp.c
into several smaller parts, go right ahead, it should not be hard.

Diego