[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Luca Abeni]

Hi Aurelien,

Aurelien Jacobs wrote:
[...]
>>>  OBJS-$(CONFIG_RTP_MUXER)                 += rtp.o rtp_h264.o rtp_mpv.o rtp_aac.o
>>> -OBJS-$(CONFIG_RTSP_DEMUXER)              += rtsp.o
>>> -OBJS-$(CONFIG_SDP_DEMUXER)               += rtsp.o
>>> +OBJS-$(CONFIG_SDP_DEMUXER)               += rtsp.o rtp.o rtp_h264.o rtp_mpv.o rtp_aac.o
>> Umm, yes, your patch makes the RTSP demuxer depend on the SDP demuxer,
>> but still I think we should keep that line here.
> 
> I agree we should keep the RTSP line here.
> Moreover, this still seems to be a dependency mess...

That is due to the fact that rtp.c contains both the muxing and demuxing 
code, and it does not contain any "#ifdef CONFIG_*"...
The second patch attached to my email was an attempt at fixing this problem.


> I feel there is a need for file splitting here (especially rtp.c).

In my second patch I added some #ifdefs instead of splitting the file 
(because I felt it was easier :). If you want, I can rewrite such patch 
splitting rtp.c instead.


> Maybe I will try to have a deeper look at it.

I was going to apply my patch (with the change suggested by Diego), but 
after reading your doubts I prefer to wait for your ok too: can I commit 
the first patch, or there is a better approach to fix the problem? 
Should I rewrite the second patch splitting rtp.c in rtp.c, rtpenc.c and 
rtpdec.c?


			Thanks,
				Luca