[FFmpeg-devel] Update on lbos

Luca Abeni lucabe72
Mon Feb 4 15:17:12 CET 2008


Hi Diego,

first of all, thanks for the comments.

Diego Biurrun wrote:
>> --- ffserver.c	(revision 11854)
>> +++ ffserver.c	(working copy)
>> @@ -20,15 +20,12 @@
>>   */
>>  
>>  #include "config.h"
>> -#ifndef HAVE_CLOSESOCKET
>>  #define closesocket close
>> -#endif
> 
>> --- libavformat/network.h	(revision 11854)
>> +++ libavformat/network.h	(working copy)
>> @@ -21,49 +21,18 @@
>>  
>> +/* most of the time closing a socket is just closing an fd */
>> +#define closesocket close
> 
> ffserver.c #includes network.h, so the #define above should be
> redundant.

You are right... I was not sure if ffserver.c should include
network.h or not (I changed my mind multiple times), and after
modifying this code for some time I ended up with this
duplication :)
I am fixing it by removing the define in ffserver.c.


			Thanks,
				Luca




More information about the ffmpeg-devel mailing list