[FFmpeg-devel] Update on lbos

[Dave Yeo]

On 02/04/08 06:17 am, Luca Abeni wrote:
> Hi Diego,
> 
> first of all, thanks for the comments.
> 
> Diego Biurrun wrote:
>>> --- ffserver.c	(revision 11854)
>>> +++ ffserver.c	(working copy)
>>> @@ -20,15 +20,12 @@
>>>   */
>>>  
>>>  #include "config.h"
>>> -#ifndef HAVE_CLOSESOCKET
>>>  #define closesocket close
>>> -#endif
>>> --- libavformat/network.h	(revision 11854)
>>> +++ libavformat/network.h	(working copy)
>>> @@ -21,49 +21,18 @@
>>>  
>>> +/* most of the time closing a socket is just closing an fd */
>>> +#define closesocket close
>> ffserver.c #includes network.h, so the #define above should be
>> redundant.
> 
> You are right... I was not sure if ffserver.c should include
> network.h or not (I changed my mind multiple times), and after
> modifying this code for some time I ended up with this
> duplication :)
> I am fixing it by removing the define in ffserver.c.
> 
> 

Here the build dies in ffserver with lots of undefined this and that 
(mostly network related) if network.h is removed from ffserver.c.
With network.h included it dies with
I:\usr\src\ffmpeg\ffserver.o(ffserver.c) : error LNK2029: "_ff_neterrno" 
: unresolved external
I:\usr\src\ffmpeg\ffserver.o(ffserver.c) : error LNK2029: "_FF_NETERROR" 
: unresolved external
which I fixed by
+#define ff_neterrno() errno
+#define FF_NETERROR(err) err
in libbrokenos/include/network.h
There is also a lot of redundant declarations currently but the build 
does work.
Dave