[FFmpeg-devel] [PATCH] define _BSD_SOURCE for bktr.c

[Diego Biurrun]

On Sat, Dec 13, 2008 at 08:47:32PM +0000, Jacob Meuser wrote:
> On Sat, Dec 13, 2008 at 12:46:56PM +0100, Diego Biurrun wrote:
> > On Sat, Dec 13, 2008 at 03:01:27AM +0000, Jacob Meuser wrote:
> > > if you have specific questions, just ask.
> > 
> > patch-libavcodec_ppc_check_altivec_c: could be acceptable.
> > 
> > patch-configure: I merged some more parts, the rest needs an explanation.
> 
> haven't kept up with what is and isn't merged.  what parts still
> need to be explained?

The patch has 17 different hunks, hunks 5-7, 13, 14 are applied, hunk
8 has been explained, the rest is mysterious.

> > patch-tests_regression_sh: half-merged, half mysterious
> 
> ports run the regression tests before installation.

Well, why don't you add the LD_LIBRARY_PATH to your script then instead
of patching regression.sh?  That would be way cleaner and not keep me
wondering what this is all about.

> > patch-libavcodec_libfaad_c,
> 
> libfaad uses e.g. long in headers and then int32_t in the actual
> library code.  that doesn't work on, say, sparc64.  so I patched
> libfaad to not use long for 32-bit values, along with all the rest
> of the ports that use faad.

Ouch.  Which version of libfaad2 does this apply to?  Have you tried
contacting them about this issue?

> > patch-subdir_mak: mysterious
> 
> I explained the subdir.mk patch long ago on this very list.

Mans just committed a cleaner solution for the first half.
The second half is not really acceptable for us.  I don't have an idea
for a clean solution offhand, but I haven't yet given it much thought.

Diego