[FFmpeg-devel] [PATCH] define _BSD_SOURCE for bktr.c

[Jacob Meuser]

On Sun, Dec 14, 2008 at 02:10:03PM +0100, Diego Biurrun wrote:
> On Sat, Dec 13, 2008 at 08:47:32PM +0000, Jacob Meuser wrote:
> > On Sat, Dec 13, 2008 at 12:46:56PM +0100, Diego Biurrun wrote:
> > > On Sat, Dec 13, 2008 at 03:01:27AM +0000, Jacob Meuser wrote:
> > > > if you have specific questions, just ask.
> > > 
> > > patch-libavcodec_ppc_check_altivec_c: could be acceptable.
> > > 
> > > patch-configure: I merged some more parts, the rest needs an explanation.
> > 
> > haven't kept up with what is and isn't merged.  what parts still
> > need to be explained?
> 
> The patch has 17 different hunks, hunks 5-7, 13, 14 are applied, hunk
> 8 has been explained, the rest is mysterious.

(1) line 884 - OpenBSD has a v4l2 header as sys/videoio.h.

(2) line 934 - use the hardware arch instead of machine arch.  this
was sent to me from another developer.

(3) line 953 - soname is generally not used on OpenBSD.  it was causing
problems, it is not necessary, so it was removed.  same with all the
linker flags.  not needed, causes problems.  OpenBSD ld is older ...

(4) line 965 - OpenBSD preferred library naming

(9) line 1531 - that was from ppc person.  I assume it is an issue
with OpenBSD/ppc or the gcc version in OpenBSD.

(10) line 1582 - no od -A in OpenBSD

(11) line 1607 - malloc.h is deprecated, use unistd.h instead.

(12) line 1717 - again, more unneeded linker flags causing problems

(15) line 1841 - linker flags ...

(16 & 17) - straighten out the library inter-dependencies.  only link
libraries that are actually needed (only resolve undefined symbols).

> > > patch-tests_regression_sh: half-merged, half mysterious
> > 
> > ports run the regression tests before installation.
> 
> Well, why don't you add the LD_LIBRARY_PATH to your script then instead
> of patching regression.sh?  That would be way cleaner and not keep me
> wondering what this is all about.

that was put there by the previous maintainer ... imo it's not all that
mysterious.  no need to wonder, just ask.

> > > patch-libavcodec_libfaad_c,
> > 
> > libfaad uses e.g. long in headers and then int32_t in the actual
> > library code.  that doesn't work on, say, sparc64.  so I patched
> > libfaad to not use long for 32-bit values, along with all the rest
> > of the ports that use faad.
> 
> Ouch.  Which version of libfaad2 does this apply to?  Have you tried
> contacting them about this issue?

at least 2.5 to 2.6.1.  I don't see how they couldn't be aware of
this.  it says one thing in the header and something else in the
actual implementation.  it's not hard to find references to this
issue via google either.

> > > patch-subdir_mak: mysterious
> > 
> > I explained the subdir.mk patch long ago on this very list.
> 
> Mans just committed a cleaner solution for the first half.
> The second half is not really acceptable for us.  I don't have an idea
> for a clean solution offhand, but I haven't yet given it much thought.

yes, that is not an easy one.  ports has a mechanism to make this
transparent with libtool, but ffmpeg doesn't use libtool (definitley
not saying it should!).

-- 
jakemsr at sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org