[FFmpeg-devel] DVCPRO HD: request for review

Michael Niedermayer michaelni
Fri Aug 29 05:52:24 CEST 2008


On Thu, Aug 28, 2008 at 09:34:41AM -0700, Roman Shaposhnik wrote:
> On Thu, 2008-08-28 at 15:48 +0200, Michael Niedermayer wrote:
> > >      assert((((int)mb_bit_buffer)&7)==0);
> > >      assert((((int)vs_bit_buffer)&7)==0);
> > > @@ -386,10 +405,18 @@ static inline void dv_decode_video_segment(DVVideoContext *s,
> > >              dc = get_sbits(&gb, 9);
> > >              dct_mode = get_bits1(&gb);
> > >              class1 = get_bits(&gb, 2);
> > > +            if (DV_PROFILE_IS_HD(s->sys)) {
> > > +                mb->idct_put = s->idct_put[0];
> > > +                mb->scan_table = s->dv_zigzag[0];
> > > +                mb->factor_table = s->dv100_idct_factor[((s->sys->height == 720)<<1)&(j < 4)][class1][quant];
> > > +                is_field_mode[mb_index] = !j && dct_mode;
> > > +            } else {
> > 
> > the dct_mode bit does nothing and can have any value for j>0 ?
> 
> Yep. That's a bit of brainfarting that croped in after too much Git'ting
> over my initial patch ;-) 

> I'll commit everything today and this piece

Iam not sure if this and your commit of 170k of unapproved code is a joke.
If it is, i do not like you humor.
Please revert it and commit the parts that have been approved cleanly
in several seperate commits.
Especially the huge tables should be reverted, adding roughly 100kb to the
size of ffmpeg by completely bypassing review and without any kind of
justification of why these tables are unavoidable is kinda nasty.

Several people including me and vitor try hard to cleanup codecs that had
been added without passing through proper review, we really do not need
more such code.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080829/70c0754e/attachment.pgp>



More information about the ffmpeg-devel mailing list