[FFmpeg-devel] DVCPRO HD: request for review

[Roman Shaposhnik]

On Thu, 2008-08-28 at 15:48 +0200, Michael Niedermayer wrote:
> >      assert((((int)mb_bit_buffer)&7)==0);
> >      assert((((int)vs_bit_buffer)&7)==0);
> > @@ -386,10 +405,18 @@ static inline void dv_decode_video_segment(DVVideoContext *s,
> >              dc = get_sbits(&gb, 9);
> >              dct_mode = get_bits1(&gb);
> >              class1 = get_bits(&gb, 2);
> > +            if (DV_PROFILE_IS_HD(s->sys)) {
> > +                mb->idct_put = s->idct_put[0];
> > +                mb->scan_table = s->dv_zigzag[0];
> > +                mb->factor_table = s->dv100_idct_factor[((s->sys->height == 720)<<1)&(j < 4)][class1][quant];
> > +                is_field_mode[mb_index] = !j && dct_mode;
> > +            } else {
> 
> the dct_mode bit does nothing and can have any value for j>0 ?

Yep. That's a bit of brainfarting that croped in after too much Git'ting
over my initial patch ;-) I'll commit everything today and this piece
will look like:
    if (!j)
        is_field_mode[mb_index] = dct_mode;

Thanks,
Roman.