[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

Ronald S. Bultje rsbultje
Wed Aug 20 20:03:12 CEST 2008


Hi,

tcpmemleak.patch: I think the malloc should go after the init &
paramchecks otherwise the return in ff_network_init() could be a
memleak. In tcp.c, I move the malloc down, and in udp.c there's too
much cruft so I moved the ff_network_init() up. Effect is the same.

After this, can I also apply tcpreturn.patch which makes invalid ports
return EINVAL instead of EIO (return value in fail: case)?

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tcpreturn.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/51e8797e/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tcpmemleak.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/51e8797e/attachment.asc>



More information about the ffmpeg-devel mailing list