[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

Michael Niedermayer michaelni
Thu Aug 21 04:42:13 CEST 2008

On Wed, Aug 20, 2008 at 02:03:12PM -0400, Ronald S. Bultje wrote:
> Hi,
> tcpmemleak.patch: I think the malloc should go after the init &
> paramchecks otherwise the return in ff_network_init() could be a
> memleak. In tcp.c, I move the malloc down, 

i think it should be moved over all goto fail* which would allow
the fail case to be simplified

> and in udp.c there's too
> much cruft so I moved the ff_network_init() up. Effect is the same.

ok, if it has been tested 

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080821/8d96f37a/attachment.pgp>

More information about the ffmpeg-devel mailing list