[FFmpeg-devel] [PATCH] mlpdec: Move quant_step_size out of substream context.

Ramiro Polla ramiro.polla
Tue Aug 12 23:24:14 CEST 2008


Since I don't have any specs for MLP, it's hard to know if this change
will introduce any regression. Probably not, since the current code
already has a similar limitation.

quant_step_size is currently defined for every channel for every
substream. I guess that all variables related to audio channels (not
matrix channels) should be the same for all substreams. So we could
save by having the channel information on a separate struct.

I have tested this with all my samples. Whenever two different streams
write quant_step_size to the same channel, it has always been the same
value. Furthermore, the code already has only enough space for each
channel (and not channel * substream) for sign_huff_offset, which is
updated whenever quant_step_size is read.

Ian, can you comment on this too please?

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quant_step_size.diff
Type: text/x-diff
Size: 3817 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080812/e7d6ba2b/attachment.diff>

More information about the ffmpeg-devel mailing list