[FFmpeg-devel] [PATCH] DAUD PCM sign fix [was: [PATCH] PCM regression tests]

Michael Niedermayer michaelni
Wed Aug 6 23:26:22 CEST 2008

On Wed, Aug 06, 2008 at 06:09:49PM +1000, pross at xvid.org wrote:
> On Tue, Aug 05, 2008 at 04:24:56PM +0200, Reimar Doeffinger wrote:
> > On Tue, Aug 05, 2008 at 11:28:43PM +1000, pross at xvid.org wrote:
> > > The DAUD PCM encoder is buggy; it currently fetches values outside of
> > > the ff_reverse[256] array when input sample values are < 0. Patch enclosed.
> > 
> > IMO do it as it is done for decoding instead: by adding a "& 0xff" to the first
> > case (there is no problem for the second case).
> > Or alternatively cast the value instead of the pointer, esp. since IMO samples should
> > be made const, and that gets really annoying then (even better use a local
> > uint16_t variable).
> Agree. Patch updated.

ok if it has been tested (=output sounds correct)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080806/2c51cca7/attachment.pgp>

More information about the ffmpeg-devel mailing list