[FFmpeg-devel] [PATCH] DAUD PCM sign fix [was: [PATCH] PCM regression tests]
pross at xvid.org
Thu Aug 7 10:29:23 CEST 2008
On Wed, Aug 06, 2008 at 11:26:22PM +0200, Michael Niedermayer wrote:
> On Wed, Aug 06, 2008 at 06:09:49PM +1000, pross at xvid.org wrote:
> > On Tue, Aug 05, 2008 at 04:24:56PM +0200, Reimar Doeffinger wrote:
> > > On Tue, Aug 05, 2008 at 11:28:43PM +1000, pross at xvid.org wrote:
> > > > The DAUD PCM encoder is buggy; it currently fetches values outside of
> > > > the ff_reverse array when input sample values are < 0. Patch enclosed.
> > >
> > > IMO do it as it is done for decoding instead: by adding a "& 0xff" to the first
> > > case (there is no problem for the second case).
> > > Or alternatively cast the value instead of the pointer, esp. since IMO samples should
> > > be made const, and that gets really annoying then (even better use a local
> > > uint16_t variable).
> > Agree. Patch updated.
> ok if it has been tested (=output sounds correct)
Yep, and it sounds fantastic.
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel