[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

Måns Rullgård mans
Wed Apr 30 00:50:42 CEST 2008


Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Apr 29, 2008 at 01:44:33PM +0100, M?ns Rullg?rd wrote:
>> 
>> Benoit Fouet wrote:
>> > Diego Biurrun wrote:
>> >> On Tue, Apr 29, 2008 at 09:18:14AM +0100, M?ns Rullg?rd wrote:
>> >>
>> >>> Diego Biurrun <diego at biurrun.de> writes:
>> >>>
>> >>>>>>> --- libavcodec/h264.c	(revision 13009)
>> >>>>>>> +++ libavcodec/h264.c	(working copy)
>> >>>>>>> @@ -8087,6 +8087,7 @@
>> >>>>>>>      .flush= flush_dpb,
>> >>>>>>> +    .long_name = "H.264 / AVC / MPEG-4 part 10",
>> >>>>>>>
>> >>>>>> I think it is MPEG-4 AVC.
>> >>>>>>
>> >>>>> As Loren also said, I think these names are more or less equivalent,
>> >>>>> AVC is often used without any reference to MPEG-4, but I don't know do
>> >>>>> as you prefer.
>> >>>>>
>> >>>> I had never heard of just "AVC" without "MPEG-4", I committed with both
>> >>>> variants.
>> >>>>
>> >>> It's quite common to call it just AVC.  For instance, that's how the
>> >>> PS3 labels it.  It also, very confusingly, common to all it just
>> >>> MPEG4, mostly in broadcast where nobody would dream of using MPEG4
>> >>> part 2.
>> >>
>> >> This sentence no verb.
>> >
>> > s/\<all/call/
>> 
>> Ben, perhaps you could share your error correction algorithm with
>> Diego the Nitpicker.
>
> I was not nitpicking, somehow I got completely confused by what you
> wrote...

Well, I must confess, there was typo or two in there...

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list