[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

[Stefano Sabatini]

On date Tuesday 2008-04-29 09:34:21 +0200, Diego Biurrun encoded:
> On Tue, Apr 29, 2008 at 12:12:29AM +0200, Stefano Sabatini wrote:
> > On date Monday 2008-04-28 12:14:47 +0200, Diego Biurrun encoded:
> > > On Mon, Apr 28, 2008 at 09:08:54AM +0200, Stefano Sabatini wrote:
> > > > On date Monday 2008-04-28 00:40:32 +0200, Diego Biurrun encoded:
[...]
> And there went the next batch...
> 
> > > > --- libavcodec/bmp.c	(revision 13009)
> > > > +++ libavcodec/bmp.c	(working copy)
> > > > @@ -257,5 +257,6 @@
> > > >      bmp_decode_end,
> > > > -    bmp_decode_frame
> > > > +    bmp_decode_frame,
> > > > +    .long_name = "BMP image",
> > > 
> > > Hmmmm
> > 
> > Well I'm somehow unsatisfied with it too, but I can't find nothing
> > better, maybe something like:
> > Microsoft BMP (BitMaP) image
> > ?
> 
> I somehow dislike adding "image" everywhere, but I cannot say that I
> have a good alternative.  Thus I will probably go with your suggestions. 
[...]
> > > > --- libavcodec/huffyuv.c	(revision 13009)
> > > > +++ libavcodec/huffyuv.c	(working copy)
> > > > @@ -1444,7 +1444,8 @@
> > > > -    NULL
> > > > +    NULL,
> > > > +    .long_name = "Huffyuv",
> > > 
> > > The multimedia wiki calls this HuffYUV :)
> > 
> > I changed it from "HuffYUV" to "Huffyuv" after Loren suggested to use:
> > "FFmpeg's Variant of Huffyuv", also the link to the official web page:
> > http://neuron2.net/www.math.berkeley.edu/benrg/huffyuv.html
> > use consistently Huffyuv instead of HuffYUV, while according to
> > wikipedia both version are correct, so I'd suggest to leave it as it
> > is or maybe to change it to:
> > Huffyuv / HuffYUV
> 
> I think I would prefer the latter then.

Yes.

> > > > --- libavcodec/tta.c	(revision 13009)
> > > > +++ libavcodec/tta.c	(working copy)
> > > > @@ -443,4 +443,5 @@
> > > >      tta_decode_frame,
> > > > +    .long_name = "TTA (The Lossless True Audio)",
> > > 
> > > I think this is just "True Audio".
> > 
> > OK.
> 
> Well, then change it :)

OK, nonetheless I think that was a better backronym ;-).

[...] 
> > > > --- libavcodec/vqavideo.c	(revision 13009)
> > > > +++ libavcodec/vqavideo.c	(working copy)
> > > > @@ -616,4 +616,5 @@
> > > >      CODEC_CAP_DR1,
> > > > +    .long_name = "Westwood Studios VQA Video",
> > > 
> > > The multimedia wiki says: "VQA stands for Vector Quantized Animation and
> > > is a FMV format used in a number of computer games by Westwood Studios."
> > 
> > What about:
> > "Westwood Studios VQA (Vector Quantized Animation) video"
> > ?
> 
> OK, but I think we can leave out the "video" here.

Mmmh again we have the VQA which is a file format which contains both
audio and video streams, so I think it is better to add "video" to
make clear we're referring to the video stream codec.

> > Sorry for the nitpicking, I'm putting in the attached patch my
> > preferred choices, I leave the final choice to you/other codec
> > maintainers.
> 
> Please be so kind and send in the next, hopefully final, update, I'll
> apply it.

New patch attached, regards.
-- 
FFmpeg = Free and Fast MultiPurpose EnGine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-missing-long-names-08.patch
Type: text/x-diff
Size: 8415 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080429/fa2e03a6/attachment.patch>